Implement algorithmic generation of Docker image names given a programming language name.#3
Merged
Conversation
There was a problem hiding this comment.
Inconsistent indentation detected.
lowjoel
force-pushed
the
generate-docker-image-names
branch
from
5ccf6c0 to
f912122
Compare
Member
There was a problem hiding this comment.
This is very hard to understand le, can we just sub ?
Member
Author
There was a problem hiding this comment.
it's actually a substring... hmm, sub would look like:
class_name.sub!(/^Coursemology::Polyglot::Language::/, '')if that's better I'll change it?
Member
There was a problem hiding this comment.
I think it would be more clear ? Until I tested in the console, then I realised 34 is the length of the string..
lowjoel
force-pushed
the
generate-docker-image-names
branch
from
f912122 to
85a9efc
Compare
…mming language name. This is needed to map a language to a suitable Docker image to use to run programs in that language.
lowjoel
force-pushed
the
generate-docker-image-names
branch
from
85a9efc to
a6ca208
Compare
Member
Author
|
@allenwq done, thanks! |
allenwq
pushed a commit
that referenced
this pull request
Jan 16, 2016
Implement algorithmic generation of Docker image names given a programming language name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to map a language to a suitable Docker image to use to run programs in that language.